mirror of
https://github.com/theoleuthardt/werkzeugkiste.git
synced 2026-06-13 09:37:53 +00:00
fix: security issue fixed by not assigning download blob url to button, instead create a html element and auto click it for download
This commit is contained in:
parent
3bcd052235
commit
b4d7bccc57
3 changed files with 31 additions and 23 deletions
|
|
@ -6,7 +6,12 @@ import { colorConvert } from "./src/routes/colorconvert.route";
|
||||||
|
|
||||||
const app = Fastify({ logger: true });
|
const app = Fastify({ logger: true });
|
||||||
|
|
||||||
app.register(cors, { origin: "*", exposedHeaders: 'Content-Disposition' });
|
app.register(cors, {
|
||||||
|
origin: "*",
|
||||||
|
exposedHeaders: "Content-Disposition",
|
||||||
|
methods: "POST",
|
||||||
|
allowedHeaders: "Content-Type",
|
||||||
|
});
|
||||||
app.register(multipart);
|
app.register(multipart);
|
||||||
app.register(libreConvert);
|
app.register(libreConvert);
|
||||||
app.register(colorConvert);
|
app.register(colorConvert);
|
||||||
|
|
|
||||||
|
|
@ -69,6 +69,7 @@ export async function libreConvert(app: FastifyInstance) {
|
||||||
"Content-Disposition",
|
"Content-Disposition",
|
||||||
`attachment; filename="converted${outputFileExt}"`,
|
`attachment; filename="converted${outputFileExt}"`,
|
||||||
)
|
)
|
||||||
|
.status(200)
|
||||||
.send(convertedBuffer);
|
.send(convertedBuffer);
|
||||||
} catch (error) {
|
} catch (error) {
|
||||||
console.error("Convert error:", error);
|
console.error("Convert error:", error);
|
||||||
|
|
|
||||||
|
|
@ -3,14 +3,12 @@ import React, { useState } from "react";
|
||||||
import Navbar from "../../components/Navbar";
|
import Navbar from "../../components/Navbar";
|
||||||
import Footer from "../../components/Footer";
|
import Footer from "../../components/Footer";
|
||||||
import Button from "../../components/Button";
|
import Button from "../../components/Button";
|
||||||
import Link from "next/link";
|
|
||||||
import { ChevronDown, ChevronUp } from "lucide-react";
|
import { ChevronDown, ChevronUp } from "lucide-react";
|
||||||
import Dropdown from "@/components/Dropdown";
|
import Dropdown from "@/components/Dropdown";
|
||||||
import { FileFormatsTable, outputFileFormats } from "@/constants";
|
import { FileFormatsTable, outputFileFormats } from "@/constants";
|
||||||
|
|
||||||
export default function DocConverter() {
|
export default function DocConverter() {
|
||||||
const [file, setFile] = useState<File | null>(null);
|
const [file, setFile] = useState<File | null>(null);
|
||||||
const [downloadUrl, setDownloadUrl] = useState<string>("");
|
|
||||||
const [loading, setLoading] = useState(false);
|
const [loading, setLoading] = useState(false);
|
||||||
const [tableOpen, setTableOpen] = useState(false);
|
const [tableOpen, setTableOpen] = useState(false);
|
||||||
const [filteredOptions, setFilteredOptions] = useState<string[]>([]);
|
const [filteredOptions, setFilteredOptions] = useState<string[]>([]);
|
||||||
|
|
@ -36,7 +34,6 @@ export default function DocConverter() {
|
||||||
}
|
}
|
||||||
|
|
||||||
setFile(selectedFile);
|
setFile(selectedFile);
|
||||||
setDownloadUrl("");
|
|
||||||
setSelectedOutputFormat("");
|
setSelectedOutputFormat("");
|
||||||
|
|
||||||
const matchedFormat = outputFileFormats.find((format) =>
|
const matchedFormat = outputFileFormats.find((format) =>
|
||||||
|
|
@ -68,15 +65,26 @@ export default function DocConverter() {
|
||||||
);
|
);
|
||||||
|
|
||||||
if (!response.ok) {
|
if (!response.ok) {
|
||||||
return new Error(`Error: ${response.statusText}`);
|
console.error(`Error: ${response.statusText}`);
|
||||||
}
|
}
|
||||||
|
|
||||||
const blob = await response.blob();
|
const blob = await response.blob();
|
||||||
const url = window.URL.createObjectURL(blob);
|
const url = window.URL.createObjectURL(blob);
|
||||||
setDownloadUrl(url);
|
const filename = file.name.split(".")[0];
|
||||||
|
|
||||||
|
const a = document.createElement("a");
|
||||||
|
a.href = url;
|
||||||
|
a.download = `${filename}${selectedOutputFormat}`;
|
||||||
|
document.body.appendChild(a);
|
||||||
|
a.click();
|
||||||
|
document.body.removeChild(a);
|
||||||
|
|
||||||
|
setTimeout(() => {
|
||||||
|
URL.revokeObjectURL(url);
|
||||||
|
}, 5000);
|
||||||
} catch (error) {
|
} catch (error) {
|
||||||
console.error("Error while converting:", error);
|
console.error("Error while converting:", error);
|
||||||
alert("Error while converting");
|
alert("Error while converting!");
|
||||||
} finally {
|
} finally {
|
||||||
setLoading(false);
|
setLoading(false);
|
||||||
}
|
}
|
||||||
|
|
@ -109,22 +117,16 @@ export default function DocConverter() {
|
||||||
/>
|
/>
|
||||||
</div>
|
</div>
|
||||||
<div className={"flex flex-row items-center gap-4 mt-4 mb-16"}>
|
<div className={"flex flex-row items-center gap-4 mt-4 mb-16"}>
|
||||||
{downloadUrl ? (
|
<Button
|
||||||
<Link id="downloadPDF" href={downloadUrl}>
|
content={
|
||||||
<Button content="download" />
|
loading ? (
|
||||||
</Link>
|
<div className="h-10 w-10 border-8 border-blue-100 border-t-blue-500 rounded-full animate-spin" />
|
||||||
) : (
|
) : (
|
||||||
<Button
|
"convert"
|
||||||
content={
|
)
|
||||||
loading ? (
|
}
|
||||||
<div className="h-10 w-10 border-8 border-blue-100 border-t-blue-500 rounded-full animate-spin" />
|
onClick={convertDoc}
|
||||||
) : (
|
/>
|
||||||
"convert"
|
|
||||||
)
|
|
||||||
}
|
|
||||||
onClick={convertDoc}
|
|
||||||
/>
|
|
||||||
)}
|
|
||||||
</div>
|
</div>
|
||||||
<div className="overflow-hidden text-xl rounded-lg border border-white mb-16 transition-all duration-300 ease-in-out hover:border-blue-400">
|
<div className="overflow-hidden text-xl rounded-lg border border-white mb-16 transition-all duration-300 ease-in-out hover:border-blue-400">
|
||||||
<div
|
<div
|
||||||
|
|
|
||||||
Loading…
Add table
Add a link
Reference in a new issue